edge cases

This commit is contained in:
Your Name 2023-05-23 15:52:48 -04:00 committed by Henri Dickson
parent 6a6a845706
commit 27f6615a18
3 changed files with 11 additions and 3 deletions

View file

@ -125,7 +125,9 @@ def retrieve(request, item_path, item_uuid):
@login_required
def create(request, item_model):
if request.method == "GET":
form_cls = CatalogForms[item_model]
form_cls = CatalogForms.get(item_model)
if not form_cls:
raise BadRequest()
form = form_cls()
return render(
request,
@ -135,7 +137,9 @@ def create(request, item_model):
},
)
elif request.method == "POST":
form_cls = CatalogForms[item_model]
form_cls = CatalogForms.get(item_model)
if not form_cls:
raise BadRequest()
form = form_cls(request.POST, request.FILES)
if form.is_valid():
form.instance.last_editor = request.user

View file

@ -926,6 +926,7 @@ class Tag(List):
@staticmethod
def cleanup_title(title, replace=True):
t = title.strip().lower()
# t = re.sub(r"\W", "_", title.strip().lower())
return "_" if not title and replace else t

View file

@ -447,7 +447,10 @@ def collection_update_member_order(request, collection_uuid):
collection = get_object_or_404(Collection, uid=get_uuid_or_404(collection_uuid))
if not collection.is_editable_by(request.user):
raise PermissionDenied()
ordered_member_ids = [int(i) for i in request.POST.get("member_ids").split(",")]
ids = request.POST.get("member_ids", "").strip()
if not ids:
raise BadRequest()
ordered_member_ids = [int(i) for i in ids.split(",")]
collection.update_member_order(ordered_member_ids)
return collection_retrieve_items(request, collection_uuid, True)