Itmens/lib.itmens
Itmens/lib.itmens
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix invalid form data error when clear ratings

Browse source
This commit is contained in:
Your Name 2021-10-15 21:08:12 -04:00
parent 1acae4f155
commit b45556cb0f
5 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
books/views.py
View file

@ -277,7 +277,7 @@ def create_update_mark(request):
form = BookMarkForm(request.POST)
if form.is_valid():
if form.instance.status == MarkStatusEnum.WISH.value:
if form.instance.status == MarkStatusEnum.WISH.value or form.instance.rating == 0:
form.instance.rating = None
form.cleaned_data['rating'] = None
form.instance.owner = request.user
@ -325,7 +325,7 @@ def create_update_mark(request):
mastodon_logger.error(f"CODE:{response.status_code} {response.text}")
return HttpResponseServerError("publishing mastodon status failed")
else:
return HttpResponseBadRequest("invalid form data")
return HttpResponseBadRequest(f"invalid form data {form.errors}")
return redirect(reverse("books:retrieve", args=[form.instance.book.id]))
else:

2
common/forms.py
View file

@ -88,7 +88,7 @@ class RatingValidator:
_('%(value)s is not an integer'),
params={'value': value},
)
if not str(value) in [str(i) for i in range(1, 11)]:
if not str(value) in [str(i) for i in range(0, 11)]:
raise ValidationError(
_('%(value)s is not an integer in range 1-10'),
params={'value': value},

4
games/views.py
View file

@ -279,7 +279,7 @@ def create_update_mark(request):
form = GameMarkForm(request.POST)
if form.is_valid():
if form.instance.status == MarkStatusEnum.WISH.value:
if form.instance.status == MarkStatusEnum.WISH.value or form.instance.rating == 0:
form.instance.rating = None
form.cleaned_data['rating'] = None
form.instance.owner = request.user
@ -328,7 +328,7 @@ def create_update_mark(request):
f"CODE:{response.status_code} {response.text}")
return HttpResponseServerError("publishing mastodon status failed")
else:
return HttpResponseBadRequest("invalid form data")
return HttpResponseBadRequest(f"invalid form data {form.errors}")
return redirect(reverse("games:retrieve", args=[form.instance.game.id]))
else:

4
movies/views.py
View file

@ -278,7 +278,7 @@ def create_update_mark(request):
form = MovieMarkForm(request.POST)
if form.is_valid():
if form.instance.status == MarkStatusEnum.WISH.value:
if form.instance.status == MarkStatusEnum.WISH.value or form.instance.rating == 0:
form.instance.rating = None
form.cleaned_data['rating'] = None
form.instance.owner = request.user
@ -327,7 +327,7 @@ def create_update_mark(request):
f"CODE:{response.status_code} {response.text}")
return HttpResponseServerError("publishing mastodon status failed")
else:
return HttpResponseBadRequest("invalid form data")
return HttpResponseBadRequest(f"invalid form data {form.errors}")
return redirect(reverse("movies:retrieve", args=[form.instance.movie.id]))
else:

8
music/views.py
View file

@ -297,7 +297,7 @@ def create_update_song_mark(request):
form = SongMarkForm(request.POST)
if form.is_valid():
if form.instance.status == MarkStatusEnum.WISH.value:
if form.instance.status == MarkStatusEnum.WISH.value or form.instance.rating == 0:
form.instance.rating = None
form.cleaned_data['rating'] = None
form.instance.owner = request.user
@ -346,7 +346,7 @@ def create_update_song_mark(request):
f"CODE:{response.status_code} {response.text}")
return HttpResponseServerError("publishing mastodon status failed")
else:
return HttpResponseBadRequest("invalid form data")
return HttpResponseBadRequest(f"invalid form data {form.errors}")
return redirect(reverse("music:retrieve_song", args=[form.instance.song.id]))
else:
@ -868,7 +868,7 @@ def create_update_album_mark(request):
form = AlbumMarkForm(request.POST)
if form.is_valid():
if form.instance.status == MarkStatusEnum.WISH.value:
if form.instance.status == MarkStatusEnum.WISH.value or form.instance.rating == 0:
form.instance.rating = None
form.cleaned_data['rating'] = None
form.instance.owner = request.user
@ -917,7 +917,7 @@ def create_update_album_mark(request):
f"CODE:{response.status_code} {response.text}")
return HttpResponseServerError("publishing mastodon status failed")
else:
return HttpResponseBadRequest("invalid form data")
return HttpResponseBadRequest(f"invalid form data {form.errors}")
return redirect(reverse("music:retrieve_album", args=[form.instance.album.id]))
else: