diff --git a/books/views.py b/books/views.py index 154f0cf6..bb6fdc9f 100644 --- a/books/views.py +++ b/books/views.py @@ -196,8 +196,8 @@ def retrieve(request, id): } ) else: - return HttpResponseBadRequest() logger.warning('non-GET method at /book/') + return HttpResponseBadRequest() @login_required diff --git a/common/scraper.py b/common/scraper.py index 0326ccbe..9d320c18 100644 --- a/common/scraper.py +++ b/common/scraper.py @@ -47,6 +47,7 @@ def log_url(func): except Exception as e: # log the url logger.error(f"Scrape Failed URL: {args[0]}") + logger.error(str(e)) raise e return wrapper @@ -115,7 +116,7 @@ def scrape_douban_book(url): # parsing starts here try: - title = content.xpath("/html/body/div[3]/h1/span/text()")[0].strip() + title = content.xpath("/html/body//h1/span/text()")[0].strip() except IndexError: raise ValueError("given url contains no book info") diff --git a/movies/views.py b/movies/views.py index 344ccefb..bace7894 100644 --- a/movies/views.py +++ b/movies/views.py @@ -198,8 +198,8 @@ def retrieve(request, id): } ) else: - return HttpResponseBadRequest() logger.warning('non-GET method at /movie/') + return HttpResponseBadRequest() @login_required